Skip to content

Update deps and docs#27

Open
ryanwinchester wants to merge 1 commit into
michalmuskala:mainfrom
ryanwinchester-forks:rw/deps-and-docs
Open

Update deps and docs#27
ryanwinchester wants to merge 1 commit into
michalmuskala:mainfrom
ryanwinchester-forks:rw/deps-and-docs

Conversation

@ryanwinchester

@ryanwinchester ryanwinchester commented Jan 7, 2024

Copy link
Copy Markdown

It's nice to see modern docs and it's nice when docs link to the repo/source code.

@ryanwinchester ryanwinchester force-pushed the rw/deps-and-docs branch 5 times, most recently from 4ff1bcf to 5f60e7a Compare January 7, 2024 02:29
@michalmuskala

michalmuskala commented Jan 9, 2024

Copy link
Copy Markdown
Owner

Thanks, this looks pretty good.

However, I think the 18.04 runner for github actions has been sunset. Could you update to 20.04?
I recently updated the Jason CI versions, if you need some reference https://github.com/michalmuskala/jason/blob/master/.github/workflows/ci.yml

@ryanwinchester

ryanwinchester commented Jan 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

However, I think the 18.04 runner for github actions has been sunset. Could you update to 20.04?

The table from erlef/setup-beam:

Operating system Erlang/OTP Status
ubuntu-18.04 17 - 25 ✅
ubuntu-20.04 20 - 25 ✅
ubuntu-22.04 24.2 - 25 ✅
windows-2019 21* - 25 ✅
windows-2022 21* - 25 ✅

means we have to change the elixir/otp combos up too i guess

@michalmuskala

michalmuskala commented Jan 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Owner

As you can see, the 18.04 jobs are just pending since github no longer provides runners with this os version.
We can start testing from OTP 20 & Elixir 1.4 similar to Jason - older versions are for a long time no longer supported and I'm fine with dropping them from automated tests.

@ryanwinchester

ryanwinchester commented Jan 11, 2024

Copy link
Copy Markdown
Author

As you can see, the 18.04 jobs are just pending since github no longer provides runners with this os version.
We can start testing from OTP 20 & Elixir 1.4 similar to Jason - older versions are for a long time no longer supported and I'm fine with dropping them from automated tests.

Yeah, you're right. Copied the Jason versions.

@ryanwinchester

ryanwinchester commented Jan 11, 2024

Copy link
Copy Markdown
Author

Should I roll back some of the deps updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanwinchester @michalmuskala